-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry consistency tests: For every version, check that each (weak)compat entry has a corresponding (weak)deps entry #525
Open
DilumAluthge
wants to merge
8
commits into
master
Choose a base branch
from
dpa/every-compat-is-dep
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b60c875
Registry consistency tests: For every version, check that each compat…
DilumAluthge 33ab32c
Fix an error
DilumAluthge 943d927
If the package has a compat entry for `julia`, there is no need to ha…
DilumAluthge fcd704e
Fix a syntax error
DilumAluthge 631ed08
Also check that every entry in WeakCompat.toml has a corresponding en…
DilumAluthge 374ff22
Merge branch 'master' into dpa/every-compat-is-dep
DilumAluthge 38b21d4
Correctly qualify a name
DilumAluthge 77ddbd2
Correctly qualify a name
DilumAluthge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't WeakDeps.toml be part of this reasoning too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should do the same thing for WeakDeps/WeakCompat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. We now do this for both Deps/Compat and also for WeakDeps/WeakCompat.
For Deps/Compat, it is legal for Compat.toml to exist but Deps.toml to not exist - specifically, if a package has no dependencies, and it has a compat entry for
julia
, then it will have Compat.toml but not Deps.toml.However, if I understand correctly, it is never legal for a package to have Compat.toml but not have Deps.toml.