Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens #514
Conversation
…, add whitespace before and after hyphens
| @@ -251,3 +251,23 @@ function test(path=pwd(); registry_deps::Vector{<:AbstractString}=String[]) | |||
| end | |||
| return nothing | |||
| end | |||
|
|
|||
| # Change all occurences of "digit-digit" to "digit - digit" | |||
| function _spacify_hyphens(str::AbstractString) | |||
There was a problem hiding this comment.
Could we instead just strip all white space from both sides? I think that would be less fragile in case there’s other white space changes later
There was a problem hiding this comment.
Or just remove all white space before comparison?
| @@ -251,3 +251,23 @@ function test(path=pwd(); registry_deps::Vector{<:AbstractString}=String[]) | |||
| end | |||
| return nothing | |||
| end | |||
|
|
|||
| # Change all occurences of "digit-digit" to "digit - digit" | |||
| function _spacify_hyphens(str::AbstractString) | |||
There was a problem hiding this comment.
Or just remove all white space before comparison?
|
Bump? Looking at CI marks in list of PRs in General is completely useless at the moment |
|
Ah, I haven't had a chance to work on this. I might not get to it until next week. @giordano If you want, you can take this PR over and work through the review comments. |
|
Might be easier to just disable nightly on general st this point... |
Seems fine. We can re-enable after this PR is merged. Can you make a PR? |
|
I completely forgot about this PR, and now I need to get it in to fix CI so we can get #516 merged and deployed. I'll make a follow-up PR to address the review comments. |
|
bors merge |
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
|
Build failed: |
BrokenRecord fails to precompile on Julia 1.11
|
bors merge |
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
|
Build failed: |
|
bors merge |
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
|
Build failed: |
|
bors merge |
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
|
Build failed: |
|
bors merge |
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
|
Build failed: |
|
bors merge |
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
|
Build failed:
|
|
bors merge |
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
|
Build failed:
|
|
I'm going to need some way (such as JuliaLang/Pkg.jl#3661) of disabling Pkg's precompilation workload in order to get the RegistryCI.jl unit tests to pass on Julia nightly. |
|
bors merge |
514: Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens r=DilumAluthge a=DilumAluthge This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186. Co-authored-by: Dilum Aluthge <[email protected]>
|
Build failed: |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
520: `pairs()` is not necessary when iterating over a `Base.Dict` r=DilumAluthge a=DilumAluthge Addresses #514 (comment) Co-authored-by: Dilum Aluthge <[email protected]>
This is necessary due to JuliaLang/Pkg.jl#3580, which made it onto Julia master in JuliaLang/julia#51186.