Pass guideline parameters in a dict #507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rough to each Guideline check! function so that each parameter doesn't need to be plumbed through separately.
DilumAluthge
changed the title
|
Huh? Is there something I need to do? I think this PR is awaiting review. |
|
@ericphanson and/or @GunnarFarneback Can you review this? |
|
I despair of anyone ever reviewing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the passing of paramneters from the various
Guidelines fromrundown to the variousGuideline.checkfunctions.Such parameters no longer need to be explicitly declared and passed through in various functions like
pull_request_build.The current passing of parameters for existing guidelines has not yet been changed. I could do that work in separate PRs if the package commiters encourage it.
This change was tested in the
guideline_linecounts_meet_thresholdsbranch of my fork, which introduces a new guideline. The unit tests ran to completion. The unit test for the new guideline succeeded.