Registry consistency tests: For every version, check that each (weak)compat entry has a corresponding (weak)deps entry #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
force-pushed
the
dpa/every-compat-is-dep
branch
from
8d731a8
to
31e9292
Compare
… entry has a corresponding deps entry
…ve `julia` listed in Deps.toml.
DilumAluthge
force-pushed
the
dpa/every-compat-is-dep
branch
from
7d83570
to
fcd704e
Compare
Comment on lines
+245
to
+247
| # Note: it is legal for a package to have Compat.toml but not have | ||
| # Deps.toml. Specifically, this is legal if (and only if) the package | ||
| # does not have any dependencies, and does have a compat entry for `julia`. |
There was a problem hiding this comment.
Shouldn't WeakDeps.toml be part of this reasoning too?
There was a problem hiding this comment.
Yeah, we should do the same thing for WeakDeps/WeakCompat.
There was a problem hiding this comment.
Done. We now do this for both Deps/Compat and also for WeakDeps/WeakCompat.
For Deps/Compat, it is legal for Compat.toml to exist but Deps.toml to not exist - specifically, if a package has no dependencies, and it has a compat entry for julia, then it will have Compat.toml but not Deps.toml.
However, if I understand correctly, it is never legal for a package to have Compat.toml but not have Deps.toml.
DilumAluthge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522