Skip to content

Commit

Permalink
Fix sequential version message (#546)
Browse files Browse the repository at this point in the history 
* fix sequential version message

* bugfix
  • Loading branch information
@ericphanson
ericphanson committed Jan 30, 2024
1 parent 5b2f5e0 commit 6043fdf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "RegistryCI"
uuid = "0c95cc5f-2f7e-43fe-82dd-79dbcba86b32"
authors = ["Dilum Aluthge <[email protected]>", "Fredrik Ekre <[email protected]>", "contributors"]
version = "10.0.0"
version = "10.0.1"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand Down
3 changes: 1 addition & 2 deletions src/AutoMerge/guidelines.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ function meets_repo_url_requirement(pkg::String; registry_head::String)
end

function _invalid_sequential_version(reason::AbstractString)
return false, "Does not meet sequential version number guideline: $(reason). If this was intentional, please leave a comment saying so. Otherwise please correct the version number in your package and re-trigger registration.", :invalid
return false, "Does not meet sequential version number guideline: $(reason). $PACKAGE_AUTHOR_APPROVAL_INSTRUCTIONS", :invalid
end

function _valid_change(old_version::VersionNumber, new_version::VersionNumber)
Expand Down Expand Up @@ -489,7 +489,6 @@ const guideline_sequential_version_number = Guideline(;
"valid new versions are `1.0.1`, `1.1.1`, `1.2.0` and `2.0.0`. ",
"Invalid new versions include `1.0.2` (skips `1.0.1`), ",
"`1.3.0` (skips `1.2.0`), `3.0.0` (skips `2.0.0`) etc.",
PACKAGE_AUTHOR_APPROVAL_INSTRUCTIONS,
),
check=data -> meets_sequential_version_number(
data.pkg,
Expand Down

2 comments on commit 6043fdf

@ericphanson
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/99893

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v10.0.1 -m "<description of version>" 6043fdf94f9f44659fdf3a94409b9a579abc5418
git push origin v10.0.1

Please sign in to comment.