Open PRs for compat entries to weak dependencies #458

sethaxen · 2023-10-19T21:31:59Z

Fixes #452

sethaxen · 2023-10-19T21:52:38Z

@DilumAluthge I'm having a little trouble understanding the test suite. Could you direct me to where I would need to make changes to test that an outdated version in [weakdeps] triggers a PR?

DilumAluthge · 2023-10-19T21:56:46Z

So, the first step is to create some new "templates", which basically just represent what the Project.toml file would look like on the master branch of some Julia package.

The templates live here: https://github.com/JuliaRegistries/CompatHelper.jl/tree/master/test/templates

Then, for the integration tests, you add these new "template packages" here: https://github.com/JuliaRegistries/CompatHelper.jl/blob/master/test/integration_tests.jl

That handles the integration tests. You'll likely also need to add some unit tests for the specific functions modified in this PR.

sethaxen · 2023-10-19T23:20:51Z

@DilumAluthge I think this is now ready for review

src/utilities/new_versions.jl

DilumAluthge · 2023-10-28T05:18:58Z

@sethaxen Can you resolve the merge conflicts?

DilumAluthge · 2023-10-28T05:19:15Z

@mattBrzezinski or @ericphanson Would you be able to take a first pass at reviewing this sometime?

DilumAluthge · 2023-10-28T11:45:06Z

Let's also see if the integration tests pass.

bors try

bors · 2023-10-28T12:15:34Z

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

mattBrzezinski · 2023-10-31T15:03:46Z

@mattBrzezinski or @ericphanson Would you be able to take a first pass at reviewing this sometime?

I might have some time this week, but I can't make any promises. I'm also offline for the next two weeks following 😬 .

sethaxen · 2023-11-16T12:18:20Z

The recent failures are unrelated to this PR. They come from Aqua v0.8, which now enforces that extras have a compat entry (ironically, the failure is because Aqua itself does not have a compat entry).

ericphanson · 2023-11-20T14:17:17Z

src/dependencies.jl

+                    end
+
+                    push!(project_deps, compat_entry)
+                    get!(dep_section, compat_entry, section)


what if a package is in multiple sections? E.g. [deps] and [weakdeps] is a documented compatibility strategy

Ah, I had thought it would make sense to always note that is in [deps] vs [weakdeps] (or in the future [extras]), but yes, the case covered in that docs page is one where one would want to highlight [weakdeps]. Perhaps then it makes sense to list no section in the PR title when the dependency is only in [deps] and otherwise give a comma-separated list of sections (currently [weakdeps] or [deps], [weakdeps])

If it’s only the title it seems like not too big of a deal either way, just wanted to make sure semantically it was OK. Maybe a simple choice is to just use deps in the title when present by looping over weak deps then deps (or vice versa if you prefer)

Ah, that's currently how this works. get!(dep_section, compat_entry, section) ensures that dep_section[compat_entry] is only set once to a section for a given package, and if the package was found in the deps section, it's already set, so weakdeps will be ignored.

If possible, I'd like the titles for regular deps to remain the same as the old titles, and for the new title format to only be used for weakdeps.

@DilumAluthge this has already been handled in 3e52390

ericphanson

This looks good to me. It seems slightly unfortunate to produce even more PRs than CompatHelper already does (i.e. we still don't have #126) but that is kind of an orthogonal point.

It would be nice also for CI to be passing, if that is an easy fix to do here. I believe Bors will refuse to merge otherwise.

ericphanson · 2023-11-20T23:31:21Z

Bump Project.toml version for a feature release (minor bump)? Then I think we're good to go.

ericphanson · 2023-11-20T23:34:43Z

BTW I wish we could do incremental rollouts of github actions, e.g. deploy to 1% of users for a day or two to make sure there's no huge issue. Would be great for wide-impact tooling like CompatHelper. I guess we could do something really silly in the action like install a different version of CompatHelper.jl based on rand(1:100)? Not sure it's worth it.

DilumAluthge · 2023-11-21T00:00:16Z

BTW I wish we could do incremental rollouts of github actions, e.g. deploy to 1% of users for a day or two to make sure there's no huge issue. Would be great for wide-impact tooling like CompatHelper. I guess we could do something really silly in the action like install a different version of CompatHelper.jl based on rand(1:100)? Not sure it's worth it.

Yeah it would be nice to have some way if staggering the rollout.

ericphanson · 2023-11-21T00:06:58Z

I guess the main thing is we don't get control over the install, as we have users do it themselves: https://github.com/JuliaRegistries/CompatHelper.jl/blob/master/.github/workflows/CompatHelper.yml. If we had our own action that handled the install, then we could implement more sophisticated strategies in it. For example, we could push a release that hardcodes the date, and scales the probability of using the new version by the number of days since that date, so e.g. after 10 days, 100% of the time it uses the new release. If there was a problem, we could then push a new release that reverts to the old version etc. Then next release we could use the time-based rollout again, etc.

ericphanson · 2023-11-21T00:41:57Z

bors merge

ericphanson · 2023-11-21T01:28:19Z

I guess bors doesn’t listen to me anymore. Maybe @DilumAluthge can do the honors here

sethaxen · 2023-12-01T21:09:11Z

@DilumAluthge is there anything else this PR needs?

DilumAluthge · 2023-12-01T21:21:46Z

Nothing needs to be done for the PR. Looks like Eric and I need to figure out how to migrate this repo from Bors to GitHub Merge Queue.

DilumAluthge · 2024-01-08T19:51:57Z

@sethaxen Can you rebase this on the latest master?

codecov · 2024-01-08T20:47:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (532fae9) 100.00% compared to head (0cffa34) 99.50%.

Additional details and impacted files

@@             Coverage Diff             @@
##            master     #458      +/-   ##
===========================================
- Coverage   100.00%   99.50%   -0.50%     
===========================================
  Files           12       12              
  Lines          398      405       +7     
===========================================
+ Hits           398      403       +5     
- Misses           0        2       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sethaxen · 2024-01-08T20:48:57Z

@DilumAluthge done!

sethaxen added 5 commits October 19, 2023 23:00

Track deps also in weakdeps

3e26709

Add dependency section to PR title

1a37f99

Fix keyword bug

fc254ae

Add section to other method

45974be

Update new_versions tests

cabbdae

DilumAluthge added the needs tests label Oct 19, 2023

sethaxen added 3 commits October 19, 2023 23:40

Update method call

313d2be

Update patch

499cc6d

Run formatter

dcc3043

sethaxen added 2 commits October 20, 2023 00:48

Add integration tests for weak dependencies

6c640c2

Place square brackets around section name in title

fcb78b0

sethaxen marked this pull request as ready for review October 19, 2023 22:58

Add unit test for get_project_deps

3978cb2

DilumAluthge requested review from mattBrzezinski and ericphanson October 26, 2023 07:28

DilumAluthge reviewed Oct 26, 2023

View reviewed changes

src/utilities/new_versions.jl Outdated Show resolved Hide resolved

DilumAluthge added the feature label Oct 26, 2023

Don't change the PR title when package is in deps section

3e52390

sethaxen added 2 commits October 28, 2023 13:11

Merge remote-tracking branch 'upstream/master' into weakdeps

4bde1bf

Increase count for pr length check

8c7b462

bors bot added a commit that referenced this pull request Oct 28, 2023

Try #458:

9f46bf5

sethaxen mentioned this pull request Oct 31, 2023

check "extras" not just "deps" ? #166

Open

Merge remote-tracking branch 'upstream/master' into weakdeps

a8420c1

devmotion mentioned this pull request Nov 15, 2023

Support ADTypes 2 and AutoForwardDiff tags tpapp/LogDensityProblemsAD.jl#21

Merged

Merge branch 'master' into weakdeps

59d661e

ericphanson reviewed Nov 20, 2023

View reviewed changes

ericphanson approved these changes Nov 20, 2023

View reviewed changes

Add missing compat entries for extras

5b8461c

Increment minor version for feature release

5e1aedf

sethaxen added 2 commits January 8, 2024 20:58

Merge branch 'master' into weakdeps

c3ea3bf

Update call to get_project_deps

0cffa34

DilumAluthge added this pull request to the merge queue Jan 8, 2024

Merged via the queue into JuliaRegistries:master with commit 18bd2a4 Jan 9, 2024
9 of 10 checks passed

sethaxen deleted the weakdeps branch May 25, 2024 08:31

andreasnoack mentioned this pull request Sep 5, 2024

Consider the extras block when checking for new versions #502

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Open PRs for compat entries to weak dependencies #458

Open PRs for compat entries to weak dependencies #458

sethaxen commented Oct 19, 2023

sethaxen commented Oct 19, 2023

DilumAluthge commented Oct 19, 2023

sethaxen commented Oct 19, 2023

DilumAluthge commented Oct 28, 2023

DilumAluthge commented Oct 28, 2023

DilumAluthge commented Oct 28, 2023

bors bot commented Oct 28, 2023

mattBrzezinski commented Oct 31, 2023

sethaxen commented Nov 16, 2023 •

edited

Loading

ericphanson Nov 20, 2023

sethaxen Nov 20, 2023 •

edited

Loading

ericphanson Nov 20, 2023

sethaxen Nov 20, 2023

DilumAluthge Nov 20, 2023

sethaxen Nov 20, 2023

ericphanson left a comment •

edited

Loading

ericphanson commented Nov 20, 2023

ericphanson commented Nov 20, 2023

DilumAluthge commented Nov 21, 2023

ericphanson commented Nov 21, 2023

ericphanson commented Nov 21, 2023

ericphanson commented Nov 21, 2023

sethaxen commented Dec 1, 2023

DilumAluthge commented Dec 1, 2023

DilumAluthge commented Jan 8, 2024

codecov bot commented Jan 8, 2024

sethaxen commented Jan 8, 2024

Open PRs for compat entries to weak dependencies #458

Open PRs for compat entries to weak dependencies #458

Conversation

sethaxen commented Oct 19, 2023

sethaxen commented Oct 19, 2023

DilumAluthge commented Oct 19, 2023

sethaxen commented Oct 19, 2023

DilumAluthge commented Oct 28, 2023

DilumAluthge commented Oct 28, 2023

DilumAluthge commented Oct 28, 2023

bors bot commented Oct 28, 2023

try

mattBrzezinski commented Oct 31, 2023

sethaxen commented Nov 16, 2023 • edited Loading

ericphanson Nov 20, 2023

Choose a reason for hiding this comment

sethaxen Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

ericphanson Nov 20, 2023

Choose a reason for hiding this comment

sethaxen Nov 20, 2023

Choose a reason for hiding this comment

DilumAluthge Nov 20, 2023

Choose a reason for hiding this comment

sethaxen Nov 20, 2023

Choose a reason for hiding this comment

ericphanson left a comment • edited Loading

Choose a reason for hiding this comment

ericphanson commented Nov 20, 2023

ericphanson commented Nov 20, 2023

DilumAluthge commented Nov 21, 2023

ericphanson commented Nov 21, 2023

ericphanson commented Nov 21, 2023

ericphanson commented Nov 21, 2023

sethaxen commented Dec 1, 2023

DilumAluthge commented Dec 1, 2023

DilumAluthge commented Jan 8, 2024

codecov bot commented Jan 8, 2024

Codecov Report

sethaxen commented Jan 8, 2024

sethaxen commented Nov 16, 2023 •

edited

Loading

sethaxen Nov 20, 2023 •

edited

Loading

ericphanson left a comment •

edited

Loading