Automatically update all Manifest files #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors merge=@DilumAluthge,@christopher-dG |
bors bot
pushed a commit
that referenced
this pull request
Nov 10, 2019
104: Automatically update all Manifest files r=DilumAluthge,christopher-dG a=DilumAluthge Closes #102 This is an expanded version of the excellent work by @christopher-dG in #102. This PR adds the following on top of the work in #102: 1. Adds tests. 2. Makes sure that we support custom registries. 3. Run jobs in a "sandbox" that does not have access to most environment variables. That way, if a package has a malicious build step, for example, they cannot steal your GitHub token. Co-authored-by: Dilum Aluthge <[email protected]>
Build failed
|
DilumAluthge
force-pushed
the
da/update_manifests
branch
from
2170f09
to
8cf3360
Compare
|
bors merge=@DilumAluthge,@christopher-dG |
bors bot
pushed a commit
that referenced
this pull request
Nov 10, 2019
104: Automatically update all Manifest files r=DilumAluthge,christopher-dG a=DilumAluthge Closes #102 This is an expanded version of the excellent work by @christopher-dG in #102. This PR adds the following on top of the work in #102: 1. Adds tests. 2. Makes sure that we support custom registries. 3. Run jobs in a "sandbox" that does not have access to most environment variables. That way, if a package has a malicious build step, for example, they cannot steal your GitHub token. --- I have been thinking about this, and it makes sense that "update all Manifests" should be the default behavior. After all, Dependabot will update your `package.json` and `package-lock.json` files by default. So we should do the same thing. It is easy enough to disable this default behavior by passing a no-op function `() -> ()` as the first positional argument to `CompatHelper.main`. That being said, because we are changing the default behavior, this is a breaking change. Co-authored-by: Dilum Aluthge <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102
This is an expanded version of the excellent work by @christopher-dG in #102. This PR adds the following on top of the work in #102:
I have been thinking about this, and it makes sense that "update all Manifests" should be the default behavior. After all, Dependabot will update your
package.jsonandpackage-lock.jsonfiles by default. So we should do the same thing. It is easy enough to disable this default behavior by passing a no-op function() -> ()as the first positional argument toCompatHelper.main.That being said, because we are changing the default behavior, this is a breaking change.