-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random sample data #93
Conversation
src/random.jl
Outdated
price_init_max = 1000.00, | ||
price_var_min = -1.0, | ||
price_var_step = 0.01, | ||
price_var_max = 0.01, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is downward trend intentional? Maybe by default should be price_var_max = 1.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
src/random.jl
Outdated
price_var_min = price_var_step, | ||
price_var_max = price_var_max, | ||
) | ||
price |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one probably is a leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed also
It would be nice to have tests, but for this it's better to add For example: using Random
function random_cl(rng::AbstractRNG = Random.default_rng();
start = Dates.DateTime(2020, 1, 1),
... # all other fields and use it internally with constructions like price_init .+ cumsum(rand(rng, price_var_min:price_var_step:price_var_max, length)) I am not sure though, if it is possible to use For compatibility reasons, one can use |
Tests have been added |
Closes #27