-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added datasource Bank of England database #85
Open
dwinrow
wants to merge
8
commits into
JuliaQuant:main
Choose a base branch
from
dwinrow:datasourceboe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
872e525
Added datasource Bank of England database
dwinrow a019cac
updated docs
dwinrow 8abab1e
updated default series to SONIA
dwinrow 4363d1f
added some error handling for invalid seriescodes
dwinrow d75a87c
improved codecov
dwinrow 533c4cf
lower case fieldnames for BoeOpt
dwinrow 321c1dd
update tests consistent with last commit
dwinrow f49adfa
included custom error types to improve compat with Julia 1
dwinrow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we use
CamelCase
for modules and type names, not for fields.Can we switch to lowercase? Like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An AbstractQueryOpt is passed to the HTTP GET command with its fieldnames and values as a query.
I chose fieldnames to be consistent with the API documentation. https://www.bankofengland.co.uk/boeapps/database/Help.asp#CSV
However, I agree that lowercase is standard for fieldnames, and since the parameter names in a HTTP GET query are case-insensitive this shouldn't cause an issue. However, underscores would not be consistent with AbstractQueryOpt as I would need to change the field names to construct the query.