Fix slow pprof for Alloc profiles: Use integer keys; stop stringifying StackFrames (it's expensive) #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stringifying the frame!
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage ? 96.59%
=======================================
Files ? 3
Lines ? 294
Branches ? 0
=======================================
Hits ? 284
Misses ? 10
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
NHDaly
force-pushed
the
nhd-allocs-perf
branch
2 times, most recently
from
46ef06a
to
d87d0f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #70, we fixed the issue in #69 (multiple stackframes hashing to the same thing) by stringifying the stack frame. This turns out to be terribly, terribly slow.
This PR instead fixes the issue by manually constructing a unique Location for each frame in the stack, by pairing the unique function ID with the line number of the frame. This is what is meant by a location: a function + a line number, so that should be a perfectly suitable unique location key.
I also added a rigorous regression-testing file, which compares the profiles produced by any branch to the profiles produced on
main. This helped me be confident in this change, and should help us prevent any issues in the future.