Expose http ports also when SSL is configured #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the nginx configuration to always listen for http requests on port 8000 and forward them to the upstream package server. In addition, the docker compose configuration is changed to map port 8001 on the host to port 8000 in the container. This make it possible to bypass nginx and connect directly to the package server. To make use of these ports one needs to be on tailnet or use SSH port forwarding. In the standard configuration ports 8000 and 8001 are both blocked by the firewall so there are no plain http ports exposed to the public.
fredrikekre
force-pushed
the
fe/ports
branch
from
768b286
to
78316cb
Compare
|
I assume this is for some kind of debugging? |
staticfloat
approved these changes
Nov 15, 2023
|
Yea -- sometimes nice to be able to reach directly into the PkgServer, and when using tailnet it seems better to use a HTTP endpoint (which is still secure because it isn't public) instead of an insecure HTTPS endpoint (insecure because hostname doesn't match). |
|
Tested on staging.pkg.julialang.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the nginx configuration to always listen for http requests on port 8000 and forward them to the upstream package server.
In addition, the docker compose configuration is changed to map port 8001 on the host to port 8000 in the container. This make it possible to bypass nginx and connect directly to the package server.
To make use of these ports one needs to be on tailnet or use SSH port forwarding. In the standard configuration ports 8000 and 8001 are both blocked by the firewall so there are no plain http ports exposed to the public.