Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

WIP: fix issues identified by MOI #354 #10

Merged
merged 6 commits into from
May 17, 2018
Merged

WIP: fix issues identified by MOI #354 #10

merged 6 commits into from
May 17, 2018

Conversation

odow
Copy link
Member

@odow odow commented May 12, 2018

Refs jump-dev/MathOptInterface.jl#354, #8

New functionality
  • support deleting VectorOfVariables-in-{Zeros,Nonnegatives,Nonpositives}
  • support deleting VectorAffineFunction-in-{Zeros,Nonnegatives,Nonpositives}
  • support deleting ScalarQuadraticFunctions including a new API method.
  • Semi-integer and Semicontinuous variables
Fixes the following bugs
  • incorrect return from get ConstraintFunction for SingleVariable-in-ZeroOne and SingleVariable-in-Integer
  • deleting scalaraffine constraints ignored the fact that there might be vectoraffine constraints as well
  • typo in addlinearconstraints!
  • candelete should check that the reference is valid. But, see candelete is inconsistent with canget jump-dev/MathOptInterface.jl#218

This was referenced May 12, 2018
Delete the quadratic constraints `start_row`, `start_row+1`, ..., `end_row` from
the model `m`.
"""
function delete_quadratic_constraints! end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquimg I added this method to the API

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Are there MOI tests for deleting quadratics?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants