Add SSSP v1.3.0#15
Merged
Merged
Conversation
Member
|
One PR should indeed update the library version 😄 |
mfherbst
reviewed
Apr 18, 2026
Member
mfherbst
left a comment
mfherbst
left a comment
There was a problem hiding this comment.
I'm also not too sure about generalising type to an array of things. The alternative is to say something like "mixed". I'm not sure that's necessarily better, but I think we should at least briefly discuss this before reaching a decision.
My arguments for having just a single type identified is:
- This is supposed to be metadata. If you cannot rely on the pseudos being of one type only, is it important what mixture of types they are at the expense of introducing the increased complexity of the two possible value types (either array or string). I am honestly not sure either way.
- What you do now (i.e. having either a string or a vector of strings) is a breaking change as downstream PseudoPotentialData will break. So it involves quite some modifications downstream.
Member
|
Looks good after the conflict is resolved we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.