Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 14 14
Lines 2969 2971 +2
=======================================
+ Hits 2796 2798 +2
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
OK, seems we cannot remove Pkgs from [extras]
There was a problem hiding this comment.
Let's do some ugly things.
| version: ${{ matrix.version }} | ||
| - uses: julia-actions/cache@v2 | ||
| - name: Remove JET | ||
| # Update this condition when JET support new version |
There was a problem hiding this comment.
This is not the right place for this "fix". One must fix the registry instead.
There was a problem hiding this comment.
Yes, I know that.
But I don't see any chance of this issue being fixed upstream anytime soon.
The pre-CI did indeed uncover some new problems.
Another idea: treat this PR as a pre-CI for master without merge it.
We just need to update or rebase this branch.
There was a problem hiding this comment.
But I don't see any chance of this issue being fixed upstream anytime soon.
Maybe you could open a PR? I don't care too much about these test failures, so I haven't spent time on it. But it should be fairly trivial.
There was a problem hiding this comment.
I generally wonder though how useful CI on pre-release versions is. See e.g. also the discussion in JuliaStats/StatsFuns.jl#194 (comment)
2 participants
No description provided.