Add docstrings for random matrix ensembles #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @dlfivefifty for review! :0) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage 39.80% 39.80%
=======================================
Files 12 12
Lines 819 819
=======================================
Hits 326 326
Misses 493 493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ah, random seeds change with version number and |
|
OK should be good to go. |
dlfivefifty
reviewed
May 22, 2025
|
|
||
| rand(W::Haar, n::Int, doCorrection::Int = 1) | ||
|
|
||
| The additional argument `doCorrection` specifies whether or not the piecewise correction |
There was a problem hiding this comment.
We should change the camel case here at some point (but as a separate PR)
dlfivefifty
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#86 First part of improving documentation for this library. The new docs build locally and examples in docstrings are now tested.