Add multiset_permutations method that doesn't require length#164
Merged
inkydragon merged 6 commits intomasterfrom May 10, 2025
Merged
Add multiset_permutations method that doesn't require length#164inkydragon merged 6 commits intomasterfrom
multiset_permutations method that doesn't require length#164inkydragon merged 6 commits intomasterfrom
Conversation
in analogy to the same case for regular `permuations`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 8 8
Lines 826 827 +1
=======================================
+ Hits 803 804 +1
Misses 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Maybe add some tests or doctests |
Member
Author
|
test added. |
Member
Author
|
should this be merged? |
thchr
reviewed
Nov 7, 2024
Co-authored-by: Thomas Christensen <tchr@mit.edu>
inkydragon
reviewed
May 2, 2025
inkydragon
reviewed
May 2, 2025
Co-authored-by: Chengyu Han <cyhan.dev@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in analogy to the same case for regular
permuations