Add support for Tables.jl #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 89.97% 89.97%
=======================================
Files 14 14
Lines 479 479
=======================================
Hits 431 431
Misses 48 48
Continue to review full report at Codecov.
|
| """ | ||
| function getobs end | ||
|
|
||
| # Generic Fallbacks | ||
| getobs(data) = data | ||
| getobs(data, idx) = data[idx] | ||
| getobs(data, idx) = istable(data) ? collect(rows(data))[idx] : data[idx] |
There was a problem hiding this comment.
Collecting all rows is too expensive, let's wait for the outcome of the discussion here
JuliaData/Tables.jl#278 (comment)
|
closing in favor of #124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty similar to what was in this comment and seems to resolve one of our issues from switching from MLDataUtils.jl.