Skip to content

Commit

Permalink
fix rpad and put! ambiguities (#172)
Browse files Browse the repository at this point in the history
* fix rpad and put! ambiguities

* Update src/deprecations.jl

Co-authored-by: Brian Chen <[email protected]>

* Update src/parallel.jl

Co-authored-by: Brian Chen <[email protected]>

* fix

* fix deprecate

---------

Co-authored-by: Brian Chen <[email protected]>
  • Loading branch information
CarloLucibello and ToucheSir authored Dec 31, 2023
1 parent 6938ff6 commit 47b1e40
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/deprecations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@
# Deprecated in v0.3
import Base: rpad
@deprecate rpad(v::AbstractVector, n::Integer, p) rpad_constant(v, n, p)
@deprecate rpad(v::AbstractVector, n::Integer, p::Union{AbstractChar, AbstractString}) rpad_constant(v, n, p)
1 change: 1 addition & 0 deletions src/parallel.jl
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ function Base.put!(f!, ringbuffer::RingBuffer)
return buf_
end

Base.put!(c::Channel, b::MLUtils.RingBuffer) = throw(MethodError(put!, (c, b)))

function Base.close(ringbuffer::RingBuffer, args...)
close(ringbuffer.results, args...)
Expand Down

0 comments on commit 47b1e40

Please sign in to comment.