Deprecate DemuxLogger for TeeLogger, that does not support include_current_global kwarg#22
Merged
Deprecate DemuxLogger for TeeLogger, that does not support include_current_global kwarg#22
include_current_global kwarg#22Conversation
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 80.32% 78.94% -1.39%
==========================================
Files 7 7
Lines 61 57 -4
==========================================
- Hits 49 45 -4
Misses 12 12
Continue to review full report at Codecov.
|
Member
|
I'm fine with the name |
Member
Author
|
I am going to merge this and leave the issue open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking at #20 I realized that including the current global logger often is not desired.
Since the default ConsoleLogger that comes with the REPL is not a pure sink,
and so one might prefer to instead point at a new
ConsoleLogger(stderr, BelowMinLevel())Plus the kwarg is longer than the function call,
plus in a deep compositional structure only at most one level would want that, so bad to default to true.
Deprecating that behavour out is hard, but deprecating to use a different logger with a new name is easy, and we wanted to change the name anyway.
Closes #1 by renaming DemuxLogger
Closes #11 by removing kwargs that interact with the
global_logger@c42f do you approve of the name? Was your suggestion originally,
or should we go for
MultiLogger?