Add apps support

[davidanthoff]

More a proof of concept at the moment.

Definition of an app looks like https://github.com/davidanthoff/examplejlapp.

To add an app:

juliaup app add https://raw.githubusercontent.com/davidanthoff/examplejlapp/main/

To run the app:

juliaup app run jlappexe1 arg1 arg2
juliaup app run jlappexe2 arg1 arg2

To remove the app:

juliaup app remove ExampleJlTestApp

Lots and lots of things that would need to be added:

• Handling of even the most basic errors :)
• Shims
• Registry story
• Updates
• Status
• Maybe the app commands should actually have their own app, like jlapp add ...
• Handle installs of apps into different depots

[davidanthoff]

Some relevant links for the next steps:

• https://learn.microsoft.com/en-us/windows/uwp/launch-resume/hosted-apps#declare-a-hosted-app
• https://learn.microsoft.com/en-us/windows/apps/desktop/modernize/grant-identity-to-nonpackaged-apps

[simeonschaub]

Are you aware of JuliaLang/Pkg.jl#3772? I think this would be good to coordinate with that PR so we don't have two completely separate notions of apps in the Julia ecosystem

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rustfmt

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/command_app_run.rs

Line 31 in 0fc1554

let julia_binary_path = &paths.juliaupconfig

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/command_app_run.rs

Line 34 in 0fc1554

.join(config_file.data.installed_versions.get(&foo.2).unwrap().path.clone())

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/command_app_run.rs

Line 37 in 0fc1554

.normalize().unwrap();

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/command_app_run.rs

Lines 48 to 50 in 0fc1554

	}
	else {

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/command_app_run.rs

Line 53 in 0fc1554

return Ok(())

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/config_file.rs

Line 59 in 0fc1554

pub target: String

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/config_file.rs

Line 73 in 0fc1554

execution_aliases: HashMap<String, JuliaupConfigExcutionAlias>

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/lib.rs

Line 7 in 0fc1554

pub mod command_app_run;

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/lib.rs

Line 9 in 0fc1554

pub mod command_completions;

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Lines 229 to 233 in 0fc1554

	pub fn download_file(
	url: &str,
	target_path: &Path,
	filename: &str
	) -> Result<()> {

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Line 239 in 0fc1554

let mut content = std::io::Cursor::new(response.bytes().unwrap());

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Lines 246 to 250 in 0fc1554

	pub fn download_file(
	url: &str,
	target_path: &Path,
	filename: &str
	) -> Result<String> {

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Lines 280 to 281 in 0fc1554

	let folder = windows::Storage::StorageFolder::GetFolderFromPathAsync(&HSTRING::from(target_path)).unwrap().get().unwrap();
	let file = folder.CreateFileAsync(&HSTRING::from(filename), windows::Storage::CreationCollisionOption::ReplaceExisting).unwrap().get().unwrap();

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Line 283 in 0fc1554

let stream = file.OpenAsync(FileAccessMode::ReadWrite).unwrap().get().unwrap();

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Line 285 in 0fc1554

http_response_content.WriteToStreamAsync(&stream).unwrap().get().unwrap();

---

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Lines 833 to 834 in 0fc1554

	JuliaupConfigApplication::DevedApplication { path: _, julia_version, julia_depot: _, execution_aliases: _ } => julia_version != installed_version
	} ) {

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

use juliaup::command_app_run::run_command_app_run;

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

	use juliaup::command_completions::run_command_completions;
	use juliaup::command_app_run::run_command_app_run;
	use juliaup::command_completions::run_command_completions;

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

	ApplicationSubCmd::Add { value } => {
	run_command_app_add(&value, &paths)
	},
	ApplicationSubCmd::Run { name, args } => {
	run_command_app_run(&name, &args, &paths)
	},
	ApplicationSubCmd::Remove { name } => run_command_app_remove(&name, &paths)
	ApplicationSubCmd::Add { value } => run_command_app_add(&value, &paths),
	ApplicationSubCmd::Run { name, args } => run_command_app_run(&name, &args, &paths),
	ApplicationSubCmd::Remove { name } => run_command_app_remove(&name, &paths),

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

	Add {
	value: String
	},
	Add { value: String },

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

	Run {
	name: String,
	args: Vec<String>
	},
	Run { name: String, args: Vec<String> },

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

	use crate::{config_file::{load_config_db, JuliaupConfigApplication}, global_paths::GlobalPaths};
	use anyhow::{Context,Result};
	use crate::{
	config_file::{load_config_db, JuliaupConfigApplication},
	global_paths::GlobalPaths,
	};
	use anyhow::{Context, Result};

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

	let target: HashMap<String,(String,String,String,String)> = config_file
	let target: HashMap<String, (String, String, String, String)> = config_file

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

	.flat_map(|i| match&i.1 {
	JuliaupConfigApplication::DevedApplication { path, julia_version, julia_depot, execution_aliases } => execution_aliases.iter().map(|j| (j.0.clone(), (j.1.target.clone(), path.clone(), julia_version.clone(), julia_depot.clone())))
	.flat_map(|i| match &i.1 {
	JuliaupConfigApplication::DevedApplication {
	path,
	julia_version,
	julia_depot,
	execution_aliases,
	} => execution_aliases.iter().map(|j| {
	(
	j.0.clone(),
	(
	j.1.target.clone(),
	path.clone(),
	julia_version.clone(),
	julia_depot.clone(),
	),
	)
	}),
	})
	.map(|i| {
	(
	i.0.clone(),
	(
	i.1 .0.clone(),
	i.1 .1.clone(),
	i.1 .2.clone(),
	i.1 .3.clone(),
	),
	)

[github-actions]

[rustfmt] _{reported by reviewdog 🐶}

Suggested change

.map(|i| (i.0.clone(), (i.1.0.clone(), i.1.1.clone(), i.1.2.clone(), i.1.3.clone())))