Apps, second attempt by davidanthoff · Pull Request #1211 · JuliaLang/juliaup

    
           pub fn download_file( 
        
               url: &str, 
        
               target_path: &Path, 
        
               filename: &str 
        
           ) -> Result<()> {

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Line 239 in bb3f735

let mut content = std::io::Cursor::new(response.bytes().unwrap());

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Lines 246 to 250 in bb3f735

    
           pub fn download_file( 
        
               url: &str, 
        
               target_path: &Path, 
        
               filename: &str 
        
           ) -> Result<String> {

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Lines 280 to 281 in bb3f735

    
           let folder = windows::Storage::StorageFolder::GetFolderFromPathAsync(&HSTRING::from(target_path)).unwrap().get().unwrap(); 
        
           let file = folder.CreateFileAsync(&HSTRING::from(filename), windows::Storage::CreationCollisionOption::ReplaceExisting).unwrap().get().unwrap();

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Line 283 in bb3f735

let stream = file.OpenAsync(FileAccessMode::ReadWrite).unwrap().get().unwrap();

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Line 285 in bb3f735

http_response_content.WriteToStreamAsync(&stream).unwrap().get().unwrap();

[rustfmt] _{reported by reviewdog 🐶}

juliaup/src/operations.rs

Lines 833 to 834 in bb3f735

    
               JuliaupConfigApplication::DevedApplication { path: _, julia_version, julia_depot: _, execution_aliases: _ } => julia_version != installed_version 
        
           } ) {

github-actions · 2025-06-17T20:02:39Z

src/bin/juliaup.rs

+use juliaup::cli::{ApplicationSubCmd, ConfigSubCmd, Juliaup, OverrideSubCmd, SelfSubCmd};
 use juliaup::command_api::run_command_api;
+use juliaup::command_app_register::run_command_app_register;
+use juliaup::command_app_run::run_command_app_run;


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

use juliaup::command_app_run::run_command_app_run;

github-actions · 2025-06-17T20:02:39Z

src/bin/juliaup.rs

+use juliaup::command_app_register::run_command_app_register;
+use juliaup::command_app_run::run_command_app_run;
+use juliaup::command_app_remove::run_command_app_remove;
 use juliaup::command_completions::run_command_completions;


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

use juliaup::command_completions::run_command_completions;

use juliaup::command_app_run::run_command_app_run;

use juliaup::command_completions::run_command_completions;

github-actions · 2025-06-17T20:02:39Z

src/bin/juliaup.rs

+            ApplicationSubCmd::Register { value } => {
+                run_command_app_register(&value, &paths)
+            },
+            ApplicationSubCmd::Run { name, args } => {
+                run_command_app_run(&name, &args, &paths)
+            },
+            ApplicationSubCmd::Remove { name } => run_command_app_remove(&name, &paths)


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

ApplicationSubCmd::Register { value } => {

run_command_app_register(&value, &paths)

},

ApplicationSubCmd::Run { name, args } => {

run_command_app_run(&name, &args, &paths)

},

ApplicationSubCmd::Remove { name } => run_command_app_remove(&name, &paths)

ApplicationSubCmd::Register { value } => run_command_app_register(&value, &paths),

ApplicationSubCmd::Run { name, args } => run_command_app_run(&name, &args, &paths),

ApplicationSubCmd::Remove { name } => run_command_app_remove(&name, &paths),

github-actions · 2025-06-17T20:02:39Z

src/cli.rs

+    Register {
+        value: String
+    },


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

Register {

value: String

},

Register { value: String },

github-actions · 2025-06-17T20:02:39Z

src/cli.rs

+    Run {
+        name: String,
+        args: Vec<String>
+    },


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

Run {

name: String,

args: Vec<String>

},

Run { name: String, args: Vec<String> },

github-actions · 2025-06-17T20:02:42Z

src/command_app_run.rs

+        .flat_map(|i| match&i.1 {
+            JuliaupConfigApplication::DevedApplication { path, julia_version, julia_depot, execution_aliases } => execution_aliases.iter().map(|j| (j.0.clone(), (j.1.target.clone(), path.clone(), julia_version.clone(), julia_depot.clone())))
+        })
+        .map(|i| (i.0.clone(), (i.1.0.clone(), i.1.1.clone(), i.1.2.clone(), i.1.3.clone())))


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

.map(|i| (i.0.clone(), (i.1.0.clone(), i.1.1.clone(), i.1.2.clone(), i.1.3.clone())))

github-actions · 2025-06-17T20:02:42Z

src/command_app_run.rs

+
+        let target_path = foo.1.clone();
+
+        let julia_binary_path = &paths.juliaupconfig


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

let julia_binary_path = &paths.juliaupconfig

let julia_binary_path = &paths

.juliaupconfig

github-actions · 2025-06-17T20:02:43Z

src/command_app_run.rs

+        let julia_binary_path = &paths.juliaupconfig
+            .parent()
+            .unwrap() // unwrap OK because there should always be a parent
+            .join(config_file.data.installed_versions.get(&foo.2).unwrap().path.clone())


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

.join(config_file.data.installed_versions.get(&foo.2).unwrap().path.clone())

.join(

config_file

.data

.installed_versions

.get(&foo.2)

.unwrap()

.path

.clone(),

)

github-actions · 2025-06-17T20:02:43Z

src/command_app_run.rs

+            .join(config_file.data.installed_versions.get(&foo.2).unwrap().path.clone())
+            .join("bin")
+            .join(format!("julia{}", std::env::consts::EXE_SUFFIX))
+            .normalize().unwrap();


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

.normalize().unwrap();

.normalize()

.unwrap();

github-actions · 2025-06-17T20:02:43Z

src/command_app_run.rs

+
+    }
+    else {


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

}

else {

} else {

github-actions · 2025-06-17T20:07:33Z

src/command_app_run.rs

+    else {
+        println!("Could not find app.");
+    }
+    return Ok(())    


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

return Ok(())

return Ok(());

github-actions · 2025-06-17T20:07:33Z

src/config_file.rs

+#[derive(Serialize, Deserialize, Clone, PartialEq)]
+pub struct JuliaupConfigExcutionAlias {
+    #[serde(rename = "Target")]
+    pub target: String


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

pub target: String

pub target: String,

github-actions · 2025-06-17T20:07:33Z

src/config_file.rs

+        #[serde(rename = "JuliaDepot")]
+        julia_depot: String,
+        #[serde(rename = "ExecutionAliases")]
+        execution_aliases: HashMap<String, JuliaupConfigExcutionAlias>


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

execution_aliases: HashMap<String, JuliaupConfigExcutionAlias>

execution_aliases: HashMap<String, JuliaupConfigExcutionAlias>,

github-actions · 2025-06-17T20:07:33Z

src/lib.rs

 pub mod command_add;
 pub mod command_api;
+pub mod command_app_register;
+pub mod command_app_run;


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

pub mod command_app_run;

github-actions · 2025-06-17T20:07:33Z

src/lib.rs

+pub mod command_app_register;
+pub mod command_app_run;
+pub mod command_app_remove;
 pub mod command_completions;


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

pub mod command_completions;

pub mod command_app_run;

pub mod command_completions;

github-actions · 2025-06-17T20:07:34Z

src/operations.rs

+            JuliaupConfigApplication::DevedApplication { path: _, julia_version, julia_depot: _, execution_aliases: _ } => julia_version != installed_version
+        } ) {


[rustfmt] _{reported by reviewdog 🐶}

Suggested change

JuliaupConfigApplication::DevedApplication { path: _, julia_version, julia_depot: _, execution_aliases: _ } => julia_version != installed_version

} ) {

JuliaupConfigApplication::DevedApplication {

path: _,

julia_version,

julia_depot: _,

execution_aliases: _,

} => julia_version != installed_version,

}) {

davidanthoff added 11 commits June 20, 2024 18:34

Add apps support

35407c4

Fix app download on Linux

f420491

Handle multi depot scenario for apps

414559e

Merge branch 'main' into apps

5e0bf3c

Remove download option

501e3b6

Change how sparse package is created

50ea0b6

Update winpkg identity

d110cae

Update add command

07018fa

Merge branch 'main' into apps

0fc1554

Remove manifest experiment

93785f1

Remove package identity experiment

cf6910c

davidanthoff changed the base branch from apps to main June 17, 2025 20:01

Progress

bb3f735

github-actions bot reviewed Jun 17, 2025

View reviewed changes

Remove old code

a2257dc

github-actions bot reviewed Jun 17, 2025

View reviewed changes

Fix some compat bugs

38b97bb

	pub fn download_file(
	url: &str,
	target_path: &Path,
	filename: &str
	) -> Result<()> {

	let folder = windows::Storage::StorageFolder::GetFolderFromPathAsync(&HSTRING::from(target_path)).unwrap().get().unwrap();
	let file = folder.CreateFileAsync(&HSTRING::from(filename), windows::Storage::CreationCollisionOption::ReplaceExisting).unwrap().get().unwrap();

	JuliaupConfigApplication::DevedApplication { path: _, julia_version, julia_depot: _, execution_aliases: _ } => julia_version != installed_version
	} ) {

	use juliaup::command_completions::run_command_completions;
	use juliaup::command_app_run::run_command_app_run;
	use juliaup::command_completions::run_command_completions;


		let target_path = foo.1.clone();

		let julia_binary_path = &paths.juliaupconfig

	let julia_binary_path = &paths.juliaupconfig
	let julia_binary_path = &paths
	.juliaupconfig

-    }
-    else {
+    } else {

Conversation

davidanthoff commented Jun 17, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant