build: Remove GPL libs when set USE_GPL_LIBS=0
#54240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkydragon
added
building
This was referenced Apr 25, 2024
|
I have tested this locally and it seems to be working. |
Maybe there are some GPL-solver related docs need to be removed. And we need JuliaSparse/SparseArrays.jl#535 to pass test. |
ViralBShah
reviewed
Aug 5, 2024
|
|
||
| remove-libsuitesparse-gpl-lib: | ||
| ifeq ($(USE_GPL_LIBS),1) | ||
| @echo This build contains [GPL-2.0+] libs: libcholmod librbio libspqr libumfpack |
There was a problem hiding this comment.
I missed that this would print every single time. I don't think the message is necessary, since we are adequately clear in our license file.
I suggest removing the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #53211