Place Pkg.build logs in Pkg's scratchspace. #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is a good idea, but don't packages that have a build step usually put a lot of other garbage there, other than the log file? |
|
True, but we should push them to use Scratch or Artifacts for that, right? |
|
Unfortunate that we are further tying |
staticfloat
approved these changes
Sep 17, 2020
fredrikekre
force-pushed
the
fe/scratch-the-build-log
branch
2 times, most recently
from
de0728d to
84f45ea
Compare
fredrikekre
force-pushed
the
fe/scratch-the-build-log
branch
from
84f45ea to
ade68cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts build logs in Pkg's scratchspace and sets the building package as the owner. This makes sure that the build log is deleted when the package is garbage collected.
The reason for this is that I am implementing #1717 and want to verify the content, but currently we pollute the package directory with the build log.