-
-
Notifications
You must be signed in to change notification settings - Fork 24
Add docstring to the rank(::QRPivoted)
method
#1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstring to the rank(::QRPivoted)
method
#1365
Conversation
d909ee3
to
23aaf7e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1365 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 34 34
Lines 15717 15717
=======================================
Hits 14745 14745
Misses 972 972 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This looks good to me. |
5cc0adc
to
9265f60
Compare
@stevengj, I'm done editing the docstring as requested (hopefully it's all okay now). Thanks for the feedback! By the way—I opened issue stevengj/nlopt#610 a few months ago, and I was wondering if you could take a look at it if you still happen to maintain that repository 🙂 |
With the release of Julia 1.12, LinearAlgebra.jl is adding dispatches for rank to SVD and QRPivoted objects, allowing the re-use of existing matrix factorizations where they have already been computed. The SVD method already has an appropriate docstring; this PR adds a near-identical one to the QRPivoted method as well, with some additional context for how it differs from the default SVD-based computation.
9265f60
to
5da8050
Compare
@stevengj, I fixed that one inaccuracy in the docstring you pointed out. Is there anything else you'd like me to change? |
Just following up, @stevengj. 🙂 |
Backported PRs: - [x] #1364 <!-- clarify eigen docstring --> - [x] #1363 <!-- Change default symmetriceigen algorithm back to RobustRepresentations --> Non-merged PRs with backport label: - [ ] #1365 <!-- Add docstring to the `rank(::QRPivoted)` method --> - [ ] #1305 <!-- Bounds-checking in triangular indexing branches -->
With the release of Julia 1.12,
LinearAlgebra.jl
is adding dispatches for rank toSVD
andQRPivoted
objects, allowing the re-use of existing matrix factorizations where they have already been computed. TheSVD
method already has an appropriate docstring; this PR adds a near-identical one to theQRPivoted
method as well, with some additional context for how it differs from the default SVD-based computation.For reference, the existing docstring for the
SVD
method is:The proposed docstring for the
QRPivoted
method follows a very similar structure, with some added context (given that QR, unlike SVD, is not the default factorization for computing rank):