Add preference for HostCPUFeatures so that it can be loaded/used #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
force-pushed
the
gb/hostcpufeatures
branch
from
d00e862 to
ef3c98e
Compare
topolarity
reviewed
Dec 16, 2025
topolarity
approved these changes
Dec 16, 2025
src/compiling.jl
Outdated
| println(io, "[HostCPUFeatures]") | ||
| println(io, "freeze_cpu_target = true") | ||
| end | ||
| # Prepend the temp env to JULIA_LOAD_PATH |
Member
There was a problem hiding this comment.
Technically appending not prepending, although I don't know which side is higher priority.
Member
|
@gbaraldi Anything you're waiting on for the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the freeze_cpu_feature preference for HostCPUFeatures.jl, which means it will freeze whatever CPU target was used for it's precompilation.
This allows it to be loaded and used, but it might lose some portability