Skip to content

Ensure correct type parameter of serialized RemoteChannel#179

Open
andreasnoack wants to merge 1 commit intomasterfrom
an/remotechannelserialize
Open

Ensure correct type parameter of serialized RemoteChannel#179
andreasnoack wants to merge 1 commit intomasterfrom
an/remotechannelserialize

Conversation

@andreasnoack
Copy link
Member

@andreasnoack andreasnoack commented Feb 14, 2026

When serializing RemoteChannels, a new zeroed RemoteChannel is constructed. However, the input type parameter might be part of an outer type parameter which can then lead to a TypeError during deserialization. The fix is just to reuse the type parameter of the input when constructing the zeroed RemoteChannel.

Fixes #178

When serializing RemoteChannels, a new zeroed RemoteChannel is
constructed. However, the input type parameter might be part of an outer
type parameter which can then lead to a TypeError during deserialization.
The fix is just to reuse the type parameter of the input when
constructing the zeroed RemoteChannel.
@andreasnoack andreasnoack force-pushed the an/remotechannelserialize branch from 303e2fe to 594f289 Compare February 14, 2026 15:28
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.34%. Comparing base (871e3d7) to head (594f289).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   79.34%   79.34%           
=======================================
  Files          10       10           
  Lines        1951     1951           
=======================================
  Hits         1548     1548           
  Misses        403      403           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DilumAluthge
Copy link
Member

I'll take a closer look tomorrow. The source code change looks okay. The tests change seems to technically remove coverage for serialize(io, ::RemoteRef), to perhaps we can refactor the tests change to cover the new case without removing coverage.

@andreasnoack
Copy link
Member Author

Serialize works recursively so it will still call serialize on the RemoteChannel once it has processed the Dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deserialization failure for some TaskFailedExceptions

2 participants