Get the demo examples working with Images 0.26. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
added a commit
that referenced
this pull request
Nov 3, 2023
|
Replaced by #40. Rather than vendor old implementations, that version switches to new implementations. |
timholy
added a commit
that referenced
this pull request
Nov 3, 2023
Closes #39 Now requires julia 1.6+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I had issues installing this package because it wasn't compatible with newer versions of Images.jl. The reason is that
Images.integral_imageandImages.boxdiffhave been deprecated. This PR is what I needed to do to make the demos work with Images 0.26. You'll probably not want to merge it as is. It looks like the plan was to have this package use IntegralArrays.jl. In that caseboxdiffshould probably be added to that package.