fix: made the gradient testing more generic#681
Merged
Conversation
Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
Contributor
Author
|
@CarloLucibello please review this |
| end | ||
|
|
||
| # AD backends to compare against the Zygote reference gradient. | ||
| ad_backends = [] |
Member
There was a problem hiding this comment.
this should be an argument to the function, with default AutoZygote.
see how it is done here
https://github.com/FluxML/NNlib.jl/blob/2e687800a16391d58fefba2b929b19f5a2509c72/test/test_module.jl#L129
…CAKE across various test files Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
Contributor
Author
|
@CarloLucibello I have made some changes, does that look alright? |
Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
Contributor
Author
|
@CarloLucibello waiting for your review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #676
The new code passes all tests.
It has been made more generic by using a helper function for running the required backend.