Skip to content

Remove deprecated api stuff #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2025
Merged

Remove deprecated api stuff #28

merged 7 commits into from
Jun 23, 2025

Conversation

j-fu
Copy link
Member

@j-fu j-fu commented Jun 13, 2025

final stage of #19

@j-fu j-fu requested a review from Copilot June 13, 2025 21:42
Copilot

This comment was marked as outdated.

@j-fu j-fu marked this pull request as draft June 13, 2025 21:47
@j-fu
Copy link
Member Author

j-fu commented Jun 13, 2025

Made it to draft, should be merged after a couple of weeks.

@j-fu j-fu marked this pull request as ready for review June 22, 2025 21:45
@j-fu j-fu requested a review from Copilot June 22, 2025 21:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes deprecated API elements, including Jupyter-specific logic and plotting functionality, as part of finalizing issue #19. Key changes include:

  • Removal of the injupyter() helper and associated Plotter parameter usage in test functions.
  • Removal of deprecated plotting functions and the triunsuitable alias.
  • Updates to the CHANGELOG documenting these breaking changes.

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/example_pointsets.jl Removed injupyter() wrappers and Plotter-dependent plotting calls.
test/example_domains.jl Removed injupyter() wrappers and Plotter-dependent plotting calls.
src/triangulateio.jl Removed deprecated triunsuitable alias.
src/Triangulate.jl Removed plotting exports and triunsuitable alias to streamline API.
CHANGELOG.md Updated version information and release notes accordingly.
Comments suppressed due to low confidence (3)

test/example_pointsets.jl:41

  • Ensure that the removal of Jupyter-specific test wrappers does not leave a coverage gap for scenarios previously run under Jupyter environments. If necessary, add tests to validate functionality in both Jupyter and headless modes.
#

test/example_domains.jl:30

  • Verify that the updated tests still cover all intended domain triangulation behaviors now that the injupyter wrapper has been removed. Consider adding alternative tests if Jupyter-specific behavior was previously critical.
end

src/Triangulate.jl:6

  • Since plotting functions have been removed, ensure that all dependent modules and documentation are updated to reflect these API changes and notify users of the migration to an external plotting package.
include("triangulateio.jl")

@j-fu j-fu merged commit c7bf1f3 into master Jun 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant