-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifies implementation of expected_loglik and add tests for it #93
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 95.69% 95.78% +0.09%
==========================================
Files 4 4
Lines 279 285 +6
==========================================
+ Hits 267 273 +6
Misses 12 12
Continue to review full report at Codecov.
|
I am not sure why, but the examples are unable to compile |
@st-- I addressed your comments and made one more change. Now there is also a "unit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to your benchmarks in #82, not quite as fast as the old code, but I like how clean it is:)
Co-authored-by: st-- <[email protected]>
The speed is more or less the same but the allocations are massively different. It would be good to compare gradients as well though. Although we could have a |
Do you want to do that within this PR? |
No, I think it deserves a PR of its own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove the atol 1e-6 -> 1e-5 change before merging it? Otherwise looks good to me.
This addresses the discussions in #82 by implementing @devmotion and adding tests for Zygote compatibility.
It adds a dependency on IrrationalConstants which was already there implicitly anyway.