Fix bitwise ops encoding and add execution tests#106
Open
0xtaruhi wants to merge 1 commit intoJuliaGPU:mainfrom
Open
Fix bitwise ops encoding and add execution tests#1060xtaruhi wants to merge 1 commit intoJuliaGPU:mainfrom
0xtaruhi wants to merge 1 commit intoJuliaGPU:mainfrom
Conversation
Member
|
Thanks. The |
0xtaruhi
force-pushed
the
fix/bitwise-ops-and-not-int
branch
from
95b5b31 to
d6f1289
Compare
0xtaruhi
changed the title
Contributor
Author
|
Updated per review feedback:
This PR now focuses purely on bitwise ops: encoding fix + |
maleadt
requested changes
Mar 9, 2026
test/execution/basic.jl
Outdated
|
|
||
| ct.launch(combined_bitwise_kernel, cld(n, tile_size), a, b, c) | ||
|
|
||
| @test Array(c) == (Array(a) .& Array(b)) .| (Array(a) .\u22bb Array(b)) |
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. Fixed it.
- Fix ShLIOp encoding to include overflow parameter - Refactor andi/ori/xori emit to use shared emit_binop! helper - Add codegen tests for bitwise ops (andi, ori, xori, shli, shri) - Add execution tests for bitwise ops to catch tileiras compilation issues
0xtaruhi
force-pushed
the
fix/bitwise-ops-and-not-int
branch
from
d6f1289 to
388e6af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShLIOpencoding to include the missingoverflowparameter (was causing tileiras crashes)andi/ori/xoriemit functions to use sharedemit_binop!helperandi,ori,xori,shli,shri)Changes
src/bytecode/encodings.jloverflowparam toencode_ShLIOp!src/compiler/intrinsics/arithmetic.jlandi/ori/xorito useemit_binop!test/codegen/operations.jltest/execution/basic.jlNotes
The
not_intsupport forfor-loop iteration has been split into a separate PR as suggested in review.