Skip to content

Conversation

@KaanKesginLW
Copy link
Contributor

The fallback memory_source(::Any) method references an undefined variable t in its error message. This causes an UndefVarError instead of the intended helpful message when passing an unsupported type to CuTexture.

Before: memory_source(::Any) = error("Unknown texture source $(typeof(t))")
After: memory_source(t::Any) = error("Unknown texture source $(typeof(t))")

The fallback method used `typeof(t)` but the parameter was anonymous.
This would cause an UndefVarError instead of the intended error message
when passing an unsupported type to CuTexture.
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.28%. Comparing base (9eb1085) to head (2c9fd46).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/texture.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2990      +/-   ##
==========================================
+ Coverage   89.15%   89.28%   +0.13%     
==========================================
  Files         148      148              
  Lines       12885    12885              
==========================================
+ Hits        11488    11505      +17     
+ Misses       1397     1380      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maleadt maleadt merged commit ca67075 into JuliaGPU:master Dec 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants