Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use YAML version traits in the parser #229

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

Use YAML version traits in the parser #229

wants to merge 64 commits into from

Commits on Jun 14, 2024

  1. Split mark and span from src/tokens.jl

    @Paalon
    Paalon committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1cf7c1e View commit details
    Browse the repository at this point in the history

  2. Add iteration and indexing to Span.

    @Paalon
    Paalon committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    60a1ece View commit details
    Browse the repository at this point in the history

  3. Add methods to get start mark and end mark from tokens.

    @Paalon
    Paalon committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f93dbb2 View commit details
    Browse the repository at this point in the history

  4. Replace token.span.start_mark and token.span.end_mark to 

    `firstmark(token)` and `lastmark(token)`.
    @Paalon
    Paalon committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    70698b3 View commit details
    Browse the repository at this point in the history

  5. Fix existing bugs about getting marks from tokens.

    @Paalon
    Paalon committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b4cd9f1 View commit details
    Browse the repository at this point in the history

  6. Replace remained expressions.

    @Paalon
    Paalon committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6efb3d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. Refactoring of scan_line_break. 

    * Performance improvement of `scan_line_break`.
* Rename `scan_line_break` to `yaml_1_1_scan_line_break`.
* Add `yaml_1_2_scan_line_break`.
* Add better comments.
* Add a TODO comment about possible bugs.
    @Paalon
    Paalon committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    1c9a97d View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Rewrite forwardchars!(::TokenStream, ::Integer). 

    * Bug fix.
* Change to use `yaml_1_1_` prefix for YAML 1.1's `forwardchars!`.
* Add `yaml_1_2_forwardchars!` for YAML 1.2's `forwardchars!`.
* Add some helper functions for `forwardchars!`:
  * `forwardchar_skip!`
  * `forwardchar_nobreak!`
  * `forwardchar_breakline!`
    @Paalon
    Paalon committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    e9c5827 View commit details
    Browse the repository at this point in the history

  2. Change to use performant and explicit function for whitespace checking.

    @Paalon
    Paalon committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a9d3d1a View commit details
    Browse the repository at this point in the history

  3. Use yaml_1_1_is_whitespace where not used.

    @Paalon
    Paalon committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a56bdce View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into scan_line_break

    @Paalon
    Paalon committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    dba3e68 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into mark-span

    @Paalon
    Paalon committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    69645b5 View commit details
    Browse the repository at this point in the history

  6. Change forward!(::BufferedInput, ::Integer) to explicitly return `n… 

    …othing`
    @Paalon
    Paalon committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    76a2aa5 View commit details
    Browse the repository at this point in the history

  7. Change _fill and __fill to better implementation and rename to 

    `buffer!`.
    @Paalon
    Paalon committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    aa04dae View commit details
    Browse the repository at this point in the history

  8. Bug fix of prefix(::BufferedInput, ::Integer). 

    Change to not overbuffer. This bug fix brake the test `windows_newlines`
but I think the test is incorrect.
    @Paalon
    Paalon committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    c4ef02d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'master' into scan_line_break

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1595c5b View commit details
    Browse the repository at this point in the history

  2. Make it explicit that scalar addition then vector addition.

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5d6632c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'bi-buffer' into bi-3

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ab9b7dd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into bi-3

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f710098 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into scanner-whitespace

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    76f857b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into scanner-whitespace-more

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    787111e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into bi-nothing

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    76bcbcc View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into mark-span

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a6c6d8f View commit details
    Browse the repository at this point in the history

  9. Remove equivalent and change to isequal and remove chomping.

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6d7dd03 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into mark-span

    @Paalon
    Paalon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9f4fe51 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'master' into bi-3

    @Paalon
    Paalon committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    dd87992 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bi-nothing

    @Paalon
    Paalon committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    7cf0234 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Merge branch 'master' into bi-nothing

    @Paalon
    Paalon committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1db5b78 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mark-span

    @Paalon
    Paalon committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0d705dd View commit details
    Browse the repository at this point in the history

  3. Remove methods for Span.

    @Paalon
    Paalon committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    acfb2b3 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Add objects to represent YAML versions. 

    Here we use abstract type & subtyping because it's common traits pattern
in Julia.
We do not need to export these objects because we can use strings for
versions in user-facing functions like:

```julia

function load(str::AbstractString; version::YAMLVersion)
    # ...
end

function load(str::AbstractString; version::AbstractString)
    version == "1.1" ? load(str, version=YAMLV1_1()) :
    version == "1.2" ? load(str, version=YAMLV1_2()) :
    throw(ErrorException())
end

load(str, version="1.1")
```
    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    73a52ff View commit details
    Browse the repository at this point in the history

  2. Use YAML version traits for b-char.

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3dbeadf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'b-char' into scan_line_break

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    689e27a View commit details
    Browse the repository at this point in the history

  4. Use better implementation because the document iterator bug has been 

    fixed.
    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    6738103 View commit details
    Browse the repository at this point in the history

  5. Use YAML version traits for scan_line_break.

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8542039 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'yamlversion' into scanner-whitespace

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3983d9c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'b-char' into scanner-whitespace

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d3358b9 View commit details
    Browse the repository at this point in the history

  8. Use YAML version traits for is_whitespace and move its definition t… 

    …o be sorted.
    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1f329f2 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'scanner-whitespace' into scanner-whitespace-more

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    331c5a2 View commit details
    Browse the repository at this point in the history

  10. Change remained yaml_1_1_is_whitespace to use YAML version traits.

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    78c04b3 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'b-char' into y11-forwardchars

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    af6dc18 View commit details
    Browse the repository at this point in the history

  12. Use YAML version traits for forwardchars!.

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    be9d213 View commit details
    Browse the repository at this point in the history

  13. Refactoring and sort out functions. 

    * Sort out functions.
* Add `b-char` for YAML 1.2.
* Add comments to `forwardchars!`.
    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    427158f View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' into bi-3

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0d82a13 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' into test-isequal

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a1a293f View commit details
    Browse the repository at this point in the history

  16. Rename get_mark to Mark.

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d9b45af View commit details
    Browse the repository at this point in the history

  17. Merge branch 'master' into scan_line_break

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    fe68efb View commit details
    Browse the repository at this point in the history

  18. Merge branch 'master' into scanner-whitespace

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5378896 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'scanner-whitespace' into scanner-whitespace-more

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a13f9ed View commit details
    Browse the repository at this point in the history

  20. Merge branch 'master' into y11-forwardchars

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    36ed962 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'master' into mark-span

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    074b04c View commit details
    Browse the repository at this point in the history

  22. Merge branch 'master' into test-isequal

    @Paalon
    Paalon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    01db7c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Merge branch 'master' into rm-get-mark

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    fa885a0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bi-nothing

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    28004f7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into bi-3

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    22251c9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'scan_line_break' into main-scan

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    9a67da0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'y11-forwardchars' into main-scan

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    beecaec View commit details
    Browse the repository at this point in the history

  6. Merge branch 'rm-get-mark' into dev-scan

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a753635 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'test-isequal' into dev-scan

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4204b0e View commit details
    Browse the repository at this point in the history

  8. Use YAML version traits for most functions in src/scanner.jl.

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    1db2624 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'mark-span' into dev-parser

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b97e9e3 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'bi-nothing' into dev-parser

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f6067a0 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'bi-3' into dev-parser

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    33f9ea5 View commit details
    Browse the repository at this point in the history

  12. Use version traits for the parser.

    @Paalon
    Paalon committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    bf84c85 View commit details
    Browse the repository at this point in the history