-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use YAML version traits in the scanner #228
Open
Paalon
wants to merge
35
commits into
JuliaData:master
Choose a base branch
from
Paalon:dev-scan
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 15, 2024
-
Refactoring of
scan_line_break
.* Performance improvement of `scan_line_break`. * Rename `scan_line_break` to `yaml_1_1_scan_line_break`. * Add `yaml_1_2_scan_line_break`. * Add better comments. * Add a TODO comment about possible bugs.
Configuration menu - View commit details
-
Copy full SHA for 1c9a97d - Browse repository at this point
Copy the full SHA 1c9a97dView commit details
Commits on Jun 17, 2024
-
Rewrite
forwardchars!(::TokenStream, ::Integer)
.* Bug fix. * Change to use `yaml_1_1_` prefix for YAML 1.1's `forwardchars!`. * Add `yaml_1_2_forwardchars!` for YAML 1.2's `forwardchars!`. * Add some helper functions for `forwardchars!`: * `forwardchar_skip!` * `forwardchar_nobreak!` * `forwardchar_breakline!`
Configuration menu - View commit details
-
Copy full SHA for e9c5827 - Browse repository at this point
Copy the full SHA e9c5827View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9d3d1a - Browse repository at this point
Copy the full SHA a9d3d1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a56bdce - Browse repository at this point
Copy the full SHA a56bdceView commit details -
Configuration menu - View commit details
-
Copy full SHA for dba3e68 - Browse repository at this point
Copy the full SHA dba3e68View commit details
Commits on Jun 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1595c5b - Browse repository at this point
Copy the full SHA 1595c5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76f857b - Browse repository at this point
Copy the full SHA 76f857bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 787111e - Browse repository at this point
Copy the full SHA 787111eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d7dd03 - Browse repository at this point
Copy the full SHA 6d7dd03View commit details
Commits on Jun 21, 2024
-
Add objects to represent YAML versions.
Here we use abstract type & subtyping because it's common traits pattern in Julia. We do not need to export these objects because we can use strings for versions in user-facing functions like: ```julia function load(str::AbstractString; version::YAMLVersion) # ... end function load(str::AbstractString; version::AbstractString) version == "1.1" ? load(str, version=YAMLV1_1()) : version == "1.2" ? load(str, version=YAMLV1_2()) : throw(ErrorException()) end load(str, version="1.1") ```
Configuration menu - View commit details
-
Copy full SHA for 73a52ff - Browse repository at this point
Copy the full SHA 73a52ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dbeadf - Browse repository at this point
Copy the full SHA 3dbeadfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 689e27a - Browse repository at this point
Copy the full SHA 689e27aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6738103 - Browse repository at this point
Copy the full SHA 6738103View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8542039 - Browse repository at this point
Copy the full SHA 8542039View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3983d9c - Browse repository at this point
Copy the full SHA 3983d9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3358b9 - Browse repository at this point
Copy the full SHA d3358b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f329f2 - Browse repository at this point
Copy the full SHA 1f329f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 331c5a2 - Browse repository at this point
Copy the full SHA 331c5a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78c04b3 - Browse repository at this point
Copy the full SHA 78c04b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for af6dc18 - Browse repository at this point
Copy the full SHA af6dc18View commit details -
Configuration menu - View commit details
-
Copy full SHA for be9d213 - Browse repository at this point
Copy the full SHA be9d213View commit details -
Refactoring and sort out functions.
* Sort out functions. * Add `b-char` for YAML 1.2. * Add comments to `forwardchars!`.
Configuration menu - View commit details
-
Copy full SHA for 427158f - Browse repository at this point
Copy the full SHA 427158fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1a293f - Browse repository at this point
Copy the full SHA a1a293fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9b45af - Browse repository at this point
Copy the full SHA d9b45afView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe68efb - Browse repository at this point
Copy the full SHA fe68efbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5378896 - Browse repository at this point
Copy the full SHA 5378896View commit details -
Configuration menu - View commit details
-
Copy full SHA for a13f9ed - Browse repository at this point
Copy the full SHA a13f9edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36ed962 - Browse repository at this point
Copy the full SHA 36ed962View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01db7c0 - Browse repository at this point
Copy the full SHA 01db7c0View commit details
Commits on Jun 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fa885a0 - Browse repository at this point
Copy the full SHA fa885a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a67da0 - Browse repository at this point
Copy the full SHA 9a67da0View commit details -
Configuration menu - View commit details
-
Copy full SHA for beecaec - Browse repository at this point
Copy the full SHA beecaecView commit details -
Configuration menu - View commit details
-
Copy full SHA for a753635 - Browse repository at this point
Copy the full SHA a753635View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4204b0e - Browse repository at this point
Copy the full SHA 4204b0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1db2624 - Browse repository at this point
Copy the full SHA 1db2624View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.