Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty rows works before the header #6

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

Drvi
Copy link
Collaborator

@Drvi Drvi commented Jul 17, 2023

and other cleanups and tests

and other cleanups and tests
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +8.50 🎉

Comparison is base (a734a34) 81.95% compared to head (417de1c) 90.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   81.95%   90.45%   +8.50%     
==========================================
  Files          10       10              
  Lines         410      419       +9     
==========================================
+ Hits          336      379      +43     
+ Misses         74       40      -34     
Impacted Files Coverage Δ
src/ChunkedBase.jl 93.33% <ø> (ø)
src/ConsumeContexts.jl 91.66% <ø> (ø)
src/parser_serial.jl 100.00% <ø> (ø)
src/parser_parallel.jl 100.00% <100.00%> (ø)
src/payload.jl 100.00% <100.00%> (ø)
src/read_and_lex.jl 96.10% <100.00%> (+2.77%) ⬆️
src/read_and_lex_utils.jl 94.23% <100.00%> (+33.40%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Drvi Drvi requested a review from quinnj July 17, 2023 14:36
@Drvi Drvi merged commit dec42da into main Jul 18, 2023
18 checks passed
@quinnj quinnj deleted the td-more-cleanup-and-tests branch July 31, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants