-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix corner cases of cut with duplicated breaks #410
Conversation
Apply more systematically the rule that all intervals are closed on the right and open on the left except the last one. Throw an error when this would lead to empty intervals unless `allowempty=true`.
It is the opposite. Intervals are closed on the left and open on the right (except the last one). But it is OK. |
Let's check whether Nanosoldier works on two packages: |
Your job submission was not accepted. Consult the server logs for more details (cc @maleadt). |
Should work now: @nanosoldier |
The package evaluation job you requested has completed - no new issues were detected. |
Number of groups was sometimes incorrect.
Apply more systematically the rule that all intervals are closed on the
rightleft and open on theleftright except the last one. Throw an error when this would lead to empty intervals unlessallowempty=true
. Handle 0.0 more systematically.Fixes #382.
I'm not sure what's the best way of handling -0.0. The current state of the PR treats it as different from 0.0, since that's consistent with our using
isless
(viasearchsortedlast
). But we could probably implement a different behavior if we wanted to. 0.0 can be confusing, but if users have it in their data they may wish to preserve it.I should also check for NaN and throw an error, which is what happened before this PR though it's undocumented and untested.