Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @JakeZw in #1158 (comment)
The zip file example was not properly closing things.
And as noted in JuliaIO/ZipArchives.jl#90, using mmap might not always be ideal.
This PR changes the example to avoid using streaming or mmap and instead buffers everything in memory to keep things simple.
I can give a more complete example based on the code in https://github.com/JuliaIO/ZipArchives.jl/blob/v2.5.1/test/test_file-array.jl
But this can get more complicated.