Skip to content

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Aug 21, 2025

As noted by @JakeZw in #1158 (comment)

The zip file example was not properly closing things.
And as noted in JuliaIO/ZipArchives.jl#90, using mmap might not always be ideal.

This PR changes the example to avoid using streaming or mmap and instead buffers everything in memory to keep things simple.

I can give a more complete example based on the code in https://github.com/JuliaIO/ZipArchives.jl/blob/v2.5.1/test/test_file-array.jl
But this can get more complicated.

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.55%. Comparing base (04ec1cf) to head (8cf0b96).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files           9        9           
  Lines        2319     2319           
=======================================
  Hits         2100     2100           
  Misses        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant