Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated writewithschema in tables.jl #20

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Updated writewithschema in tables.jl #20

merged 2 commits into from
Apr 20, 2024

Commits on Apr 15, 2024

  1. Update tables.jl 

    addressed write Vector size issue (17): the first row was taken as the underlying multiplier of the buffer, causing failures should subsequent rows be larger (with at least one >5% larger than the first).

adjusted the strategy to initially find the maximum row size, leveraging this as the buffer multiplier.

a more sensible approach would be to sum the row sizes, to create an exact buffer vector, but I am unaware of potential downstream impacts
    @djholiver
    djholiver committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    24c9278 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from djholiver/djholiver-patch-1-issue17 

    Update tables.jl
    @djholiver
    djholiver committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7141175 View commit details
    Browse the repository at this point in the history