export sqs_messages function #6
Conversation
|
ping @samoconnor |
|
is this package deprecated? It seems that AWSSDK is preferred. |
|
removed the export function, but add some missing packages to fix the test error. |
|
Hi @jingpengw, sorry about the delayed response. See the AWSCore.jl doc:
|
| @@ -20,11 +20,11 @@ export sqs_list_queues, sqs_get_queue, sqs_create_queue, sqs_delete_queue, | |||
|
|
|||
|
|
|||
| using AWSCore | |||
| using SymDict | |||
| using AWSSDK.SQS | |||
There was a problem hiding this comment.
AWSSQS.jl does not need AWSSDK.jl
It calls AWSCore.Services.sqs, defined here: https://github.com/JuliaCloud/AWSCore.jl/blob/master/src/Services.jl#L1572
| using HTTP | ||
|
|
||
| using MbedTLS |
There was a problem hiding this comment.
any reason for changing the order of HTTP and MbedTLS?
There was a problem hiding this comment.
Nope, just the SymDict was needed. Otherwise it won't compile.
There was a problem hiding this comment.
Are you saying the order of using SymDict was an issue? What was the error message?
REQUIRE
Outdated
| Retry | ||
| MbedTLS | ||
| HTTP 0.5.4 | ||
| HTTP |
There was a problem hiding this comment.
Was the presence of the minimum versions in REQUIRE causing a problem for you?
There was a problem hiding this comment.
probably not, I did not know that this is minimum version. was thinking about required version.
There was a problem hiding this comment.
added back of the tags.
| @@ -16,15 +16,15 @@ export sqs_list_queues, sqs_get_queue, sqs_create_queue, sqs_delete_queue, | |||
| sqs_set_policy, sqs_name, sqs_arn, | |||
| sqs_send_message, sqs_send_message_batch, sqs_receive_message, | |||
| sqs_delete_message, sqs_flush, sqs_get_queue_attributes, sqs_count, | |||
| sqs_busy_count | |||
| sqs_busy_count, sqs_messages | |||
There was a problem hiding this comment.
I'm hesitant to export the iterator because it has no test cases and needs a bit more work to be user friendlily. At present, it doesn't behave nicely if there are no more messages.
Note: beb67ce
If you're using it and would like to write some test cases that would be great!
otherwise the example in README.md won't work.