Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set USE_GPL_LIBS=0 for x86_64-w64-mingw32nogpl #350

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

build: set USE_GPL_LIBS=0 for x86_64-w64-mingw32nogpl #350

wants to merge 3 commits into from

Conversation

inkydragon
Copy link
Contributor

@inkydragon inkydragon commented Apr 25, 2024 •
edited
Loading

CI :windows: build x86_64-w64-mingw32nogpl passed, because the USE_GPL_LIBS=0 flag is not

Use same flags as macOS:

julia-buildkite/pipelines/scheduled/platforms/build_macos.no_gpl.arches

Line 2 in ea50eb7

macos x86_64-apple-darwinnogpl x86_64 USE_GPL_LIBS=0,JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror .

@inkydragon inkydragon mentioned this pull request Apr 25, 2024
Closed
@DilumAluthge DilumAluthge added automerge Kodiak will auto-merge this PR once all CI is green. (This label was previously called "merge me".) and removed automerge Kodiak will auto-merge this PR once all CI is green. (This label was previously called "merge me".) labels Oct 26, 2024
@DilumAluthge
Copy link
Member

Actually, let's make sure that the no-GPL build is green before we add the automerge label.

@inkydragon
Copy link
Contributor Author

inkydragon commented Nov 28, 2024 •
edited
Loading

With JL_CFLAGS=-Werror,JL_CXXFLAGS=-Werror, We need to fix all warning issued by gcc14 or the build will fail.

JuliaLang/julia#56579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge DilumAluthge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inkydragon @DilumAluthge @IanButterworth