-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow optional src_path argument to generate that default to URL #174
Conversation
Instead of using the copier.yml from ~/.julia/** use GH url. Fixes #146
If the argument is passed, copy from that location, otherwise url the URL. BREAKING CHANGE: The default API now clones from the URL, which means that even if you clone the repo and run the generate command, it will use the latest tagged version.
Zenodo failures are 50x. |
@sverhoeven I'm not sure I understood your second bullet point. This is testing the generation of the template using wrapper (Julia) vs direct (copier) in two situations: using the source "URL#main", and using the source "dir of cloned/added package". |
@sverhoeven would you like to review, or should I ask @suvayu? |
In the original commit the URL was hard coded, so if you opened a PR in this repo, CI would still run on a template url that points to main, not the branch in the PR. In the test, if you are passing a fixed url (haven't looked at your commit yet), then it should be passing the url for the PR branch for the test to be correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test needs to address the 2nd bullet.
Explained offline that this actually addresses the second bullet point and the PR was approved then. |
@allcontributors add @suvayu for review |
I've put up a pull request to add @suvayu! 🎉 |
Instead of using the copier.yml from ~/.julia/** use GH url.
TODO
Related issues
Fixes #146
Checklist