-
Notifications
You must be signed in to change notification settings - Fork 4
Implement caching of SVO filters #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 80.60% 76.76% -3.84%
==========================================
Files 6 6
Lines 366 396 +30
==========================================
+ Hits 295 304 +9
- Misses 71 92 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/svo.jl
Outdated
errval = simple_value(children(info)[1]) | ||
if errval == "Filter not found:" | ||
errval *= " $id" | ||
filename = joinpath(filter_cache, replace(filtername, "/" => "_") * "_" * string(magsys) * ".txt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would save these as .xml
files instead
It works really well and looks good to me! I have added one comment in the review (xml vs. txt files) and also added a PR adding One thing one could still add is a keyword argument to |
Implements caching of filters queried from SVO. Includes an
update_filters()
function that will redownload all cached filters from SVO, effectively refreshing the cache.@lucasvalenzuela how does this look?