Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fit_data_scitype fallback from Unknown to Tuple{Unknown} #22

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jan 28, 2022

Because fit_data_scitype is always a tuple type or union of tuple types.

@ablaom ablaom marked this pull request as draft January 28, 2022 03:56
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #22 (445ac28) into dev (b3e4064) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           58        58           
=========================================
  Hits            58        58           
Impacted Files Coverage Δ
src/StatisticalTraits.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e4064...445ac28. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants