Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for feature importance on regression #38

Closed
wants to merge 1 commit into from

Conversation

ExpandingMan
Copy link
Collaborator

addressed #37

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #38 (9a3d40d) into master (bc3ecef) will increase coverage by 0.79%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   53.96%   54.76%   +0.79%     
==========================================
  Files           1        1              
  Lines         126      126              
==========================================
+ Hits           68       69       +1     
+ Misses         58       57       -1     
Impacted Files Coverage Δ
src/MLJXGBoostInterface.jl 54.76% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

This PR adds a test for XGBoostCount
We still need:

  • feature importance test for XGBoostRegressor
  • serialize/deserialize test for XGBoostCount
  • serialize/deserialize test for XGBoostRegressor

@ExpandingMan
Copy link
Collaborator Author

Ok, I'll add them when I get a chance.

@ExpandingMan
Copy link
Collaborator Author

I messed up my branches, so I'm closing this, it'll be replaced in a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants