Skip to content

Commit

Permalink
Merge pull request #44 from JuliaAI/rh/loosen-test-values
Browse files Browse the repository at this point in the history
Loosen test thresholds
  • Loading branch information
rikhuijzer authored Oct 9, 2023
2 parents a72f9d3 + e67235f commit 7fe96e2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ XGBoost = "009559a3-9522-5dbb-924b-0b6ed2b22bb9"
[compat]
MLJModelInterface = "1.5"
Tables = "1.0.5"
XGBoost = "2.0.1 - 2.3.2"
XGBoost = "2.0.1"
julia = "1.6"

[extras]
Expand Down
4 changes: 2 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ end
selectrows(X, train), y[train];)
yhat = mode.(predict(plain_classifier, fitresult, selectrows(X, test)))
misclassification_rate = sum(yhat .!= y[test])/length(test)
@test misclassification_rate < 0.015
@test misclassification_rate < 0.025

# Multiclass{10} case:
N=10
Expand All @@ -121,7 +121,7 @@ end

yhat = mode.(predict(plain_classifier, fitresult, selectrows(X, test)))
misclassification_rate = sum(yhat .!= y[test])/length(test)
@test misclassification_rate < 0.01
@test misclassification_rate < 0.03

# check target pool preserved:
X = (x1=rand(rng, 400), x2=rand(rng, 400), x3=rand(rng, 400))
Expand Down

0 comments on commit 7fe96e2

Please sign in to comment.