Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For a 0.15.10 release #469

Merged
merged 24 commits into from
Aug 22, 2022
Merged

For a 0.15.10 release #469

merged 24 commits into from
Aug 22, 2022

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Aug 4, 2022

#462 #468 #463

To do:

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #469 (adf82cb) into master (831b117) will increase coverage by 1.50%.
The diff coverage is 14.60%.

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   75.42%   76.93%   +1.50%     
==========================================
  Files          12       16       +4     
  Lines        1050     1097      +47     
==========================================
+ Hits          792      844      +52     
+ Misses        258      253       -5     
Impacted Files Coverage Δ
src/MLJModels.jl 100.00% <ø> (ø)
src/registry/src/activate_registry_project.jl 0.00% <0.00%> (ø)
src/registry/src/check_registry.jl 0.00% <0.00%> (ø)
src/registry/src/update.jl 0.00% <0.00%> (ø)
src/registry/test/info_dict.jl 92.00% <ø> (ø)
src/loading.jl 67.94% <77.77%> (+5.59%) ⬆️
src/builtins/Transformers.jl 96.24% <100.00%> (ø)
src/init.jl 100.00% <100.00%> (ø)
src/registry/src/Registry.jl 100.00% <100.00%> (+100.00%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ablaom
Copy link
Member Author

ablaom commented Aug 5, 2022

Needs resolution of: JuliaAI/MLJScikitLearnInterface.jl#42

@ablaom ablaom closed this Aug 21, 2022
@ablaom ablaom reopened this Aug 21, 2022
@ablaom
Copy link
Member Author

ablaom commented Aug 21, 2022

@OkonSamuel Can you please add your hack to .github/workflows/check_registry.yml to (hopefully) resolve the fail here?

@OkonSamuel
Copy link
Member

OkonSamuel commented Aug 22, 2022

@OkonSamuel Can you please add your hack to .github/workflows/check_registry.yml to (hopefully) resolve the fail here?

@ablaom
I worked on it in #470, but the check_registry.yml still fails due to MissingImputator and GMMClusterer.
On further investigation, I found out that MLJ registry load paths for GMMClusterer and MissingImputor are invalid. See https://github.com/JuliaAI/MLJModels.jl/blob/ldpath/src/registry/Metadata.toml#L269, https://github.com/JuliaAI/MLJModels.jl/blob/dev/src/registry/Metadata.toml#L301, https://github.com/sylvaticus/BetaML.jl/blob/v0.7.1/src/Imputation/Imputation_MLJ.jl#L251,
https://github.com/sylvaticus/BetaML.jl/blob/v0.7.1/src/GMM/GMM_MLJ.jl#L149

@ablaom ablaom merged commit 6026869 into master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants