Merge pull request #542 from JuliaAI/dev

For a 0.16.3 release - take II
JuliaAI · Jan 10, 2024 · d1701d8 · d1701d8
2 parents 93ea7dc + 3dcdf3a
commit d1701d8
Show file tree

Hide file tree

Showing 3 changed files with 406 additions and 285 deletions.
diff --git a/.github/workflows/check_registry.yml b/.github/workflows/check_registry.yml
@@ -18,10 +18,6 @@ jobs:
           - x64
     env:
       PYTHON: Conda
-      # remove next line (and others marked below) when 
-      # JuliaAI/MLJScikitLearnInterface.jl#42 properly resolved
-      # LD_LIBRARY_PATH: /home/runner/.julia/conda/3/lib
-
     steps:
       - uses: actions/checkout@v2
       - uses: julia-actions/setup-julia@v1
@@ -42,17 +38,7 @@ jobs:
       - run: julia -e 'using Pkg; Pkg.Registry.update()'
       - run: julia -e 'using Pkg; Pkg.develop(Pkg.PackageSpec(path = pwd()))'
       - run: julia -e 'using Pkg; Pkg.add("Test")'
-
-      # remove next eight lines (and one other marked above) when 
-      # JuliaAI/MLJScikitLearnInterface.jl#42 gets properly resolved
-      #- name: "Install Conda"
-      #  run: julia -e 'using Pkg; Pkg.add("Conda");'
-      #- name: "Install Scikit-learn"
-      #  run: |
-      #    julia -e 'using Conda; Conda.add("scikit-learn");'\
-      #    cd $LD_LIBRARY_PATH #just to check that the path is valid
-      #  
-      -	 run: julia -e 'using Pkg; Pkg.update()'
+      - run: julia -e 'using Pkg; Pkg.update()'
       - run: julia -e 'using Pkg; Pkg.precompile()'
       - run: julia -e 'using Pkg; Pkg.status()'
       - run: julia -e 'using MLJModels; using Test; problems = MLJModels.check_registry(); @info("", length(problems), problems); @test(isempty(problems))'