Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "eval in closed module" issue #71

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Fix "eval in closed module" issue #71

merged 3 commits into from
Oct 14, 2020

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Oct 14, 2020

@ablaom ablaom changed the base branch from master to dev October 14, 2020 23:05
@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #71 into dev will increase coverage by 7.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #71      +/-   ##
==========================================
+ Coverage   91.70%   99.04%   +7.33%     
==========================================
  Files           9        9              
  Lines         205      209       +4     
==========================================
+ Hits          188      207      +19     
+ Misses         17        2      -15     
Impacted Files Coverage Δ
src/model_def.jl 100.00% <100.00%> (ø)
src/equality.jl 100.00% <0.00%> (ø)
src/metadata_utils.jl 100.00% <0.00%> (ø)
src/model_traits.jl 100.00% <0.00%> (+41.37%) ⬆️
src/parameter_inspection.jl 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab2762...49baa47. Read the comment docs.

@ablaom ablaom merged commit 594e8c6 into dev Oct 14, 2020
@ablaom ablaom mentioned this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants