-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for implementation of Affinity Propagation #28
Conversation
@Yuan-Ru-Lin I see this is a draft. Please go ahead and ping me when you are ready for a review. No hurry. |
The code is ready to be reviewed. I basically just made the model Two dependencies are added: Oh I should mention that I use |
@ablaom Forgot to ping you! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
===========================================
- Coverage 96.10% 79.34% -16.76%
===========================================
Files 1 1
Lines 77 92 +15
===========================================
- Hits 74 73 -1
- Misses 3 19 +16 ☔ View full report in Codecov by Sentry. |
@Yuan-Ru-Lin This is looking great. Thanks for taking the time to wrap your head around the MLJ API and the docstring requirements. Can you add some basic test that include:
You can bump Julia support in the Project to 1.10 (hopefully fixes your fail) and, if you know how, do the same bump in .github/workflows/ci.yaml - otherwise I can do it. |
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Hi @ablaom, I have
|
@ablaom Morning from PST! The PR is ready to be reviewed again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @Yuan-Ru-Lin for this valuable contribution.
Implement interface of Affinity Propagation to MLJ. The implementation mimics that of KMedoids and directly uses the existing
MMI.predict