Conversation
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 94.73% 98.41% +3.67%
==========================================
Files 1 1
Lines 38 63 +25
==========================================
+ Hits 36 62 +26
+ Misses 2 1 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
OkonSamuel
reviewed
Aug 25, 2022
Member
Author
|
Thanks @OkonSamuel for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #11. Builds on JuliaAI/MLJBase.jl#806, which was not available at that time.
Adds an interface for the DBSCAB model, implementing it as a
Staticmodel (no fit), as the model does not generalize to new data. Assignments are returned bypredict; DBSCAN point types (core/boundary/noise) are accessed from the post-predict report. Detailed MLJ-compliant doc-string included.